GitLab

Using a convoluted while loop that changes the len variable is not
recommended.

Also, make the diff volatile so we are sure the compiler does not do
some unwanted optimization.
Acked-by: David Goulet <dgoulet@ev0ke.net>

Slightly tweaked by Ian Goldberg <ian@cypherpunks.ca>

Fixes #22

Related to #20

 that submitted a wrong patch due to bad understanding
thus the reason of this commit.
Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Fixes #20

Fixes #18
Acked-by: David Goulet <dgoulet@ev0ke.net>
Signed-off-by: Julien Voisin <julien.voisin@dustri.org>

The most important feature here is that the compilation is now silent
thus it's now much more easier to spot warnings/errors by the compiler.

To make it verbose, simply use "make V=1".

Fixes #11
Signed-off-by: David Goulet <dgoulet@ev0ke.net>

This is to initialize automatically the repository with autoreconf.
It's the common name to use for that script (also used is "autogen.sh").

Update INSTALL file with bootstrap script

Fixes #10
Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Fixes #9
Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Fixes #5
Acked-by: Nikita Borisov <me+otr.im@nikita.ca>
Acked-by: David Goulet <dgoulet@ev0ke.net>
Signed-off-by: Julien Voisin <julien.voisin@dustri.org>

Thanks to jvoisin <julien.voisin@dustri.org> for the suggestion.

Return 0 instead of crashing from otrl_proto_query_bestversion if passed
an illegal input.  Thanks to Conrad Hoffmann <ch@bitfehler.net> for the
report and the patch.

Mostly in the documentation, but also in the default OTR Query message.

Before, trying to fragment a message into more than 65535 pieces would
cause incorrect fragments to be output.

Now, it just returns an error (as that is disallowed by the spec).

Thanks to Teemu Huovila <thuovila@cs.helsinki.fi> for reporting the issue.

The spec (but not the code) incorrectly said "128 bits" before.

Passing a private key value of 0 to otr_sesskeys would cause libgcrypt
to crash in gcry_mpi_powm.  We reported this libgcrypt bug and it was
then fixed in
http://lists.gnupg.org/pipermail/gcrypt-devel/2013-July/002251.html
but the workaround is simply to use gcry_mpi_new(DH1536_MOD_LEN_BITS)
instead of gcry_mpi_new(0).

Note that this only affected the otr_sesskeys toolkit program, and not
libotr itself.

Thanks to the Mayhem Team at CMU (Alexandre Rebert, Thanassis Avgerinos,
Sang Kil Cha, David Brumley, Manuel Egele) for the report.

The inject_message callback was missing the opdata when sending message
fragments.
Signed-off-by: David Goulet <dgoulet@ev0ke.net>

This fixes a case where the first user message
gets lost when OTRL_POLICY_REQUIRE_ENCRYPTION
policy is set because after establishing the
encryption lastmessage remains with the master
context and will not be resent.

[Slightly modified by Ian Goldberg]

Thanks to Daniel Atallah <datallah@pidgin.im> for noticing that it
wasn't working before.

Don't have otrl_init call exit(1) if the application's requested version
number differs from libotr's.  Rather, return a non-zero error code, and
have the application clean up gracefully.  The OTRL_INIT macro now
checks the error code and does an exit(1) as the default behaviour, but
the application can do what it likes.

The new timer_control callback will instruct the application to call the
new otrl_message_poll function in order to actually clear out the above
stale committed keys.

This will be used to clear the committed key from the master context
once we don't expect any more instances of our buddy to respond with a
DHKEY message.

Thanks to Kjell Braden <kb@pentabarf.de> for noticing the omission.

libotr was exporting exactly two functions without the otrl_ prefix:
context_priv_new and context_priv_force_finished.  Change the names of
these functions to start with otrl_.  Thanks to David Goulet
<dgoulet@ev0ke.net> for noticing it.

Don't update the recent_sent_child field to point to the master context
just becuase we sent a version 3 COMMIT message (which has no
destination instance).

Similarly to the previous commit, if we receive a COMMIT message, we
should just use it to start a new SIGMA protocol, rather than comparing
it against the old COMMIT message we may have still lying around.  This
completely removes the need for the otrl_auth_copy_on_commit function.

If we receive a COMMIT message after sending our own COMMIT, it used to
be the case that this was a simultaneous attempt to start OTR from each
side.  Now it's much more likely that one side sent its COMMIT some time
in the past, but it stuck around in the master context, just in case
some other logged in instance of the buddy is still going to respond
with a DHKEY message.  So if we now receive a COMMIT *to* the master
context, ignore the old COMMIT we sent, and always use the received one
to start a new SIGMA protocol.

If debugging is enabled, and you type ?OTR!!, all contexts will be
dumped to stderr.

If OTRL_DEBUGGING is set, add functions to dump the internal
state of a ConnContext to a FILE*.

Consider copying the master auth context to the child, even if the child
is already in ENCRYPTED, because we might be trying to refresh a private
conversation.

checks for support LD support for -pie, --dynamicbase,
and --nxcompat on win32.

checks for support of CC support for -fPIE.

    These new compiler and linker hardening options may be disabled at
    your own peril with the following options to configure:

      --disable-gcc-hardening, disable compiler security checks
      --disable-linker-hardening, disable linker security fixups