Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • L libotr
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 50
    • Issues 50
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Libraries
  • libotr
  • Issues
  • #142

Closed
Open
Created Apr 27, 2020 by Jurre van Bergen@DrWhaxMaintainer

Regressions in Alpine test suite

While testing out libotr on Alpine I came across:

/libotr/tests # ./run.sh test_list
unit/test_auth ................................. ok
unit/test_proto ................................ Failed 2/48 subtests
unit/test_dh ................................... ok
unit/test_b64 .................................. Failed 1/10 subtests
unit/test_context .............................. ok
unit/test_userstate ............................ ok
unit/test_tlv .................................. ok
unit/test_mem .................................. ok
unit/test_sm ................................... ok
unit/test_instag ............................... ok
unit/test_privkey .............................. ok
regression/random-msg.sh ....................... ok
regression/random-msg-auth.sh .................. ok
regression/random-msg-fast.sh .................. ok
regression/random-msg-frag.sh .................. ok
regression/random-msg-disconnect.sh ............ ok
regression/random-msg-disconnect-frag.sh ....... ok
regression/random-msg-disconnect-auth.sh ....... ok
regression/random-msg-disconnect-frag-auth.sh .. ok

Test Summary Report
-------------------
unit/test_proto                              (Wstat: 0 Tests: 48 Failed: 2)
  Failed tests:  13, 15
unit/test_b64                                (Wstat: 0 Tests: 10 Failed: 1)
  Failed test:  6
Files=19, Tests=3337, 50 wallclock secs ( 0.69 usr  0.15 sys +  4.61 cusr  0.59 csys =  6.04 CPU)
Result: FAIL

In specific:

/libotr/tests # ./unit/test_b64
1..10
ok 1 - Call with no prefix returned an error
ok 2 - Call with no suffix returned an error
ok 3 - Decode b64 with message of len 0
ok 4 - Invalid b64 data
ok 5 - Call with valid data successfull
not ok 6 - Decoded valid b64 test vector with success
#     Failed test (test_b64.c:test_otrl_base64_otr_decode() at line 67)
ok 7 - Decode b64 with invalid b64 characters
ok 8 - Encoded b64 test vector with success
ok 9 - Decoded previously encoded test vector
ok 10 - Decoded value is exact
# Looks like you failed 1 test of 10.
/libotr/tests # ./unit/test_proto
1..48
ok 1 - OTRv2 default query message is valid
ok 2 - OTRv23 default query message is valid
ok 3 - OTRv3 default query message is valid
ok 4 - The best from query2 is 2
ok 5 - The best from query3 is 3
ok 6 - The best from query23 is 2
ok 7 - The best from query23 is 3
Expected libotr API version 5.0.0 incompatible with actual version 4.1.1.  Aborting.
ok 8 - Too recent major version
ok 9 - Api number unchanged
Expected libotr API version 3.0.0 incompatible with actual version 4.1.1.  Aborting.
ok 10 - Too old major version
ok 11 - Api number unchanged
Expected libotr API version 4.2.0 incompatible with actual version 4.1.1.  Aborting.
ok 12 - Too recent minor version
not ok 13 - Api number unchanged
#     Failed test (test_proto.c:test_otrl_init() at line 179)
ok 14 - Inferior minor version
not ok 15 - Api number unchanged
#     Failed test (test_proto.c:test_otrl_init() at line 184)
ok 16 - Exact version
ok 17 - Api version set for exact version
ok 18 - Best version whitespace v2
ok 19 - Best version whitespace v2 dual policy
ok 20 - Best version whitespace v3
ok 21 - Best version whitespace v3 dual policy
ok 22 - Best version whitespace invalid
ok 23 - Proto message type is not OTR
ok 24 - Proto message type is tagged plaintext
ok 25 - Proto message type v2 is dh commit
ok 26 - Proto message type v3 is dh commit
ok 27 - Proto message type v2 is DH key
ok 28 - Proto message type v3 is DH key
ok 29 - Proto message type v2 is revealsig
ok 30 - Proto message type v3 is revealsig
ok 31 - Proto message type v2 is a signature
ok 32 - Proto message type v3 is a signature
ok 33 - Proto message type v2 is a data msg
ok 34 - Proto message type v3 is a data msg
ok 35 - Proto message type is a query
ok 36 - Proto message type is a query
ok 37 - Proto message type is an error
ok 38 - Proto message type is unknown
ok 39 - Proto message type is unknown
ok 40 - Protocol message version is 2
ok 41 - Protocol message version is 3
ok 42 - Protocol message version is unknown
ok 43 - Proto instance find for v3
ok 44 - Proto instance failed for v3
ok 45 - Proto instance failed for v2
ok 46 - Otrl version OK
ok 47 - Conflict detected for msgstate plaintext
ok 48 - Conflict detected for msgstate encrypted
# Looks like you failed 2 tests of 48.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking