Return values not checked from otrl_dh_gen_keypair
The return value of otrl_dh_gen_keypair is not checked. The function can fail if the groupid parameter is invalid, and subsequent code would then use an uninitialized keypair. In most calls the groupid paramter is hardcoded. In the future, otrl_dh_gen_keypair may have more failure paths, or the groupid parameter may be more likely to be wrong (e.g., negotiated, configured).
The attached patch updates all occurences in src/. It builds but hasn't been tested (due to Bug 8).
(from redmine: created on 2014-11-15)
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information