Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • L libotr
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 50
    • Issues 50
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Libraries
  • libotr
  • Issues
  • #65

Closed
Open
Created Apr 01, 2016 by GregZ@porkbun-otr

Return values not checked from otrl_dh_gen_keypair

The return value of otrl_dh_gen_keypair is not checked. The function can fail if the groupid parameter is invalid, and subsequent code would then use an uninitialized keypair. In most calls the groupid paramter is hardcoded. In the future, otrl_dh_gen_keypair may have more failure paths, or the groupid parameter may be more likely to be wrong (e.g., negotiated, configured).

The attached patch updates all occurences in src/. It builds but hasn't been tested (due to Bug 8).

(from redmine: created on 2014-11-15)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking