Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • L libotr-ng
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 21
    • Issues 21
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • Deployments
    • Deployments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • OTRv4
  • libotr-ng
  • Merge requests
  • !209

Closed
Created Aug 11, 2019 by Jurre van Bergen@DrWhaxOwner
  • Report abuse
Report abuse

Remove redundant wrapper functions for otrng_bool

  • Overview 3
  • Commits 1
  • Changes 6

Created by: osmk

The otrng_bool is compatible with the C standard boolean logic so the otrng_bool_is_true wrapper isn't needed. The conversion function c_bool_to_otrng_bool is unused across the code base and can also be safely removed.

The intent of this change is to declutter the code a bit. For otrng_bool_is_true to serve as an abstraction, one would have to apply it consistently wherever otrng_bool is examined. That would clutter the code for little practical value though so it seems better to just remove it.

It's possible of course that I misunderstand the purpose of otrng_bool, and perhaps there are future plans conflicting with this change. If so I apologise for the noise! :)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: github/fork/osmk/remove-redundant-boolean-abstraction